(no subject)

[zwol]

API hall of shame (names redacted to protect the guilty): I have just found a class that must be used as follows:

void foo(Input *in, Output *out)
{
  Processor proc;
  proc->SetOutput(out);
  proc->Process(in, out->ThingOne(), 
                out->ThingTwo(), out->ThingThree());
}

Process() retrieves ThingOne through ThingThree itself, and asserts that its caller passed the same values. I could not make this shit up if I tried.

Comments

[kaolinfire.livejournal.com]

wtf?

wow.

[zwol.livejournal.com]

There's some archaeological indication that SetOutput and Process used to be called very far from one another, but that's not an excuse for making Process' caller retrieve Thing[123], which AFAICT have always been available from the Output object.